Skip to content

Conversation

@atorch
Copy link
Owner

@atorch atorch commented Aug 26, 2025

Make sure we get a red 🟥 ❌ 🔥 from github actions

@atorch atorch requested a review from Copilot August 26, 2025 04:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR intentionally introduces failing tests and CI configuration changes to verify that GitHub Actions properly fails and displays error indicators. The changes are designed to break the build pipeline for testing purposes.

  • Adds an incorrect assertion in AnswerCheckerTest that will fail
  • Changes a UI test to look for a non-existent button resource
  • Adds a new locale to the CI matrix that may not be properly configured

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
AnswerCheckerTest.java Adds a failing assertion with incorrect expected value for e*pi calculation
PuzzleSelectionTest.java Changes button lookup from level_0 to level_5 resource string
actions.yml Adds 'fr-FR' locale to the CI test matrix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

strategy:
matrix:
locale: ['en-US', 'de-DE', 'es-ES', 'ar-EG']
locale: ['en-US', 'de-DE', 'es-ES', 'ar-EG', 'fr-FR']
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, we don't have a fr-FR translation, shouldn't this blow up?

@atorch atorch closed this Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant