Skip to content

DecimalFormat is "Locale sensitive" #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DecimalFormat is "Locale sensitive" #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions ARODataAnalyzer/src/com/att/aro/main/TimeRangeAnalysisDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,11 @@
import java.awt.Window;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.math.BigDecimal;
import java.math.RoundingMode;
import java.text.DecimalFormat;
import java.text.MessageFormat;
import java.text.ParseException;
import java.util.ResourceBundle;

import javax.swing.BorderFactory;
Expand Down Expand Up @@ -194,9 +197,8 @@ public void actionPerformed(ActionEvent arg0) {

// Rounding traceEndTime as getEndTimeTextField() to
// handle time comparison
Double traceEndTimeRounded = Double
.valueOf(decimalFormat.format(traceEndTime));
if (startTime < endTime) {
Double traceEndTimeRounded = new BigDecimal(traceEndTime).setScale(2, RoundingMode.HALF_UP).doubleValue();
if (startTime < endTime) {
if (((startTime >= 0.0) && (startTime <= traceEndTimeRounded))
&& ((endTime >= 0.0) && (endTime <= traceEndTimeRounded))) {

Expand Down Expand Up @@ -294,7 +296,13 @@ private JTextField getStartTimeTextField() {
* Returns the start time from the start time field
*/
private Double getTimeValue(JTextField field) throws NumberFormatException {
return Double.parseDouble(field.getText());
Number value= null;
try {
value = decimalFormat.parse(field.getText());
} catch (ParseException e) {
throw new NumberFormatException();
}
return value.doubleValue();
}

/**
Expand Down
14 changes: 11 additions & 3 deletions ARODataAnalyzer/src/com/att/aro/main/menu/view/ExcludeTimeRangeAnalysisDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,11 @@
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.io.IOException;
import java.math.BigDecimal;
import java.math.RoundingMode;
import java.text.DecimalFormat;
import java.text.MessageFormat;
import java.text.ParseException;
import java.util.ResourceBundle;

import javax.swing.BorderFactory;
Expand Down Expand Up @@ -215,8 +218,7 @@ public void actionPerformed(ActionEvent arg0) {

// Rounding traceEndTime as getEndTimeTextField() to
// handle time comparison
Double traceEndTimeRounded = Double
.valueOf(DECIMAL_FORMAT.format(traceEndTime));
Double traceEndTimeRounded = new BigDecimal(traceEndTime).setScale(2, RoundingMode.HALF_UP).doubleValue();
if (startTime < endTime) {
if (((startTime >= 0.0) && (startTime <= traceEndTimeRounded))
&& ((endTime >= 0.0) && (endTime <= traceEndTimeRounded))) {
Expand Down Expand Up @@ -318,7 +320,13 @@ private JTextField getStartTimeTextField() {
* Returns the start time from the start time field
*/
private Double getTimeValue(JTextField field) throws NumberFormatException {
return Double.parseDouble(field.getText());
Number value= null;
try {
value = DECIMAL_FORMAT.parse(field.getText());
} catch (ParseException e) {
throw new NumberFormatException();
}
return value.doubleValue();
}

/**
Expand Down