This commit fixes an issue in the release-on-tag.yml workflow where…
#18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the release title was being set to a literal command string instead of its output. The previous method of using command substitution `$(...)` directly within an action's `with` block is not a reliable way to execute shell commands in GitHub Actions. This fix corrects the issue by introducing a dedicated step (`Get Release Title`) to first run the `sed` command and then store its result in a step output variable. The subsequent `Create Release` step then references this output to set the release name. This is the standard and robust method for handling dynamic values in GitHub Actions. This commit also ensures the `softprops/action-gh-release` action is updated to `v2` and that the `RELEASE_TITLE.txt` file does not contain a trailing newline.
…d`) to include links to the recently added documentation for Prettier and repository badges. The following links have been added: - A link to `docs/prettier.md` - A link to `docs/badges.md` This makes the new documentation discoverable from the main documentation page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the release title was being set to a literal command string instead of its output.
The previous method of using command substitution
$(...)directly within an action'swithblock is not a reliable way to execute shell commands in GitHub Actions.This fix corrects the issue by introducing a dedicated step (
Get Release Title) to first run thesedcommand and then store its result in a step output variable. The subsequentCreate Releasestep then references this output to set the release name. This is the standard and robust method for handling dynamic values in GitHub Actions.This commit also ensures the
softprops/action-gh-releaseaction is updated tov2and that theRELEASE_TITLE.txtfile does not contain a trailing newline.Description
Related Issue
Checklist