-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiprocessing for Process, Feature, Segment #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2024
hagenw
force-pushed
the
test-multiprocessing
branch
from
March 25, 2024 18:52
f193076
to
bfd8e34
Compare
hagenw
force-pushed
the
test-multiprocessing
branch
2 times, most recently
from
March 26, 2024 07:57
6f92932
to
1e9f056
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
hagenw
changed the title
TST: test for multiprocessing=True
Fix multiprocessing for Process, Feature, Segment
Mar 26, 2024
maxschmitt
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #165
Ensure, that the
multiprocessing
argument ofaudinterface.Process
,audinterface.Feature
,audinterface.Segment
does not result in an pickle related error, if set toTrue
. Multiprocessing relies on pickling all involved objects to communicate between processes.The error was originally reported in audeering/opensmile-python#104.
I added tests for
audinterface.Process
,audinterface.Feature
,audinterface.Segment
, to detect the error.Most tests included already the
multiprocessing
argument, but it was always set toFalse
.The reason for the error consisted of two parts:
The problem is that
Process._process_func_signature
cannot be pickled.To fix this, I changed the code to
process_func=None
is selected, we provide default process functions. Before they were defined on the fly inside the object, which also results in objects that cannot be pickled. This is solved here, by defining the functions outside of the actual objects./cc @frankenjoe