Open
Conversation
Contributor
|
Just tested and this works. It now panics if POLY_FUNDER is not set, and sets it automatically in the body if it is set. Great job. |
Contributor
|
Before closing, I had a question about the form of the client. For reference, this is how I would instantiate a Pythonic version of the Polymarket client: client = ClobClient(
"https://clob.polymarket.com",
key=pk,
chain_id=POLYGON,
signature_type=1,
funder=funder,
)The L1 auth is baked into this, so as a user, you don't need to care about doing it yourself. Also, if you have different naming for environment variables, or for any other reason don't want to use environment variables, you can't use the current flow. It would be nice as a feature to be able to do this with polysqueeze: let poly_client = ClobClient::new(&pk, &funder); // chain, url, & signature type are defaulted to 137, ..., & 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue #7
Description
Removed the need of calling
.set_funder()to authenticate, which used to cause unnecessary friction.The funder now gets set during auth with L2 headers (constructor panics in case
POLY_FUNDERis not set.)Updated examples to reflect the update.