-
Notifications
You must be signed in to change notification settings - Fork 22
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This helps Arduino compatibility. Of course, this whole situation is an excellent case in point to illustrate why, if you _must_ use macros, _never_ to give them such easily collidable names. But that is not the users' fault, so since we can work around the problem, we do so. The `B1` template parameter can be renamed to `B` without loss of readability. `PI` is a little more challenging. We do use it in one place in our code, in defining `Degrees`, so we must replace that with its definition of `Magnitude<Pi>{}`. We provide workaround instructions in the comments. We leave alone the many instances of `PI` in test files, since that shouldn't affect these users. Helps #246.
- Loading branch information
Showing
3 changed files
with
18 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters