Add -pedantic to EXTRA_COPTS
#210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our godbolt link is broken! https://godbolt.org/z/KrvfhP4M3 To fix this robustly, we add the `-pedantic` option to our builds. We put it in `EXTRA_COPTS` instead of `BASE_CLANG_COPTS` because otherwise, the warning doesn't show up when we run this repro command: ```sh bazel clean && bazel build --config=gcc //au:constant_test ``` This PR fixes all of the other warnings that started showing up when I added this compiler option, too. Interestingly, the godbolt-breaking problem (extra `;`) seems like it shows up only for gcc's `-pedantic` implementation, not clang's.
chiphogg
added
the
release notes: ⚙️ repo
|
I intentionally delayed fixing the offending error just to double-check that CI would catch it. It would! Job link: https://github.com/aurora-opensource/au/actions/runs/7187543317/job/19575326547?pr=210 |
geoffviola
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our godbolt link is broken! https://godbolt.org/z/KrvfhP4M3
To fix this robustly, we add the
-pedanticoption to our builds. Weput it in
EXTRA_COPTSinstead ofBASE_CLANG_COPTSbecause otherwise,the warning doesn't show up when we run this repro command:
bazel clean && bazel build --config=gcc //au:constant_testThis PR fixes all of the other warnings that started showing up when I
added this compiler option, too. Interestingly, the godbolt-breaking
problem (extra
;) seems like it shows up only for gcc's-pedanticimplementation, not clang's.