Add foundations for CMake support #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We start by creating the top-level `CMakeLists.txt` file, following the modern CMake guide (https://cliutils.gitlab.io/modern-cmake/). We already have a `build/` directory, so we'll use `cmake/build` for our build folder. We add this to `.gitignore` (using a `*` so as to support multiple build folders). We update the release instructions so as to keep the version number in sync, and the installation instructions so as to explain how to use CMake. Helps #215.
chiphogg
added
the
release notes: ⚙️ repo
geoffviola
reviewed
Jul 2, 2024
| # The maximum version should be the latest version we've tested the project with. | ||
| # | ||
| # [1]: https://cliutils.gitlab.io/modern-cmake/chapters/intro/dodonot.html | ||
| cmake_minimum_required(VERSION 3.23...3.29) |
There was a problem hiding this comment.
Any reason that you chose cmake 3.23? Ubuntu 22.04.4 LTS packages cmake 3.22.1 😄
There was a problem hiding this comment.
Yep, the comment above explains the reasoning.
CMake is in some ways counter-intuitive, at least to me. There's a strong expectation that it will be very easy for users to get the latest version, and thus there are community norms around aggressively updating the minimum version. I will say, I was pleased to see how easy it was to grab 3.29 on Ubuntu, simply by adding the official PPA.
There was a problem hiding this comment.
Sounds good. I followed this SO post and the code below worked.
geoffviola
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We start by creating the top-level
CMakeLists.txtfile, following themodern CMake guide (https://cliutils.gitlab.io/modern-cmake/).
We already have a
build/directory, so we'll usecmake/buildfor ourbuild folder. We add this to
.gitignore(using a*so as to supportmultiple build folders).
We update the release instructions so as to keep the version number in
sync, and the installation instructions so as to explain how to use
CMake.
Helps #215.