UPSTREAM PR #2037: fix: add HaikuOS support for GetTID() in sysinfo.cc#18
Open
loci-dev wants to merge 1 commit into
Open
UPSTREAM PR #2037: fix: add HaikuOS support for GetTID() in sysinfo.cc#18loci-dev wants to merge 1 commit into
loci-dev wants to merge 1 commit into
Conversation
Add a platform-specific GetTID() implementation for HaikuOS using Haiku's native find_thread(NULL) API, which returns the current thread's ID. Without this, HaikuOS falls through to the generic pthread_self() fallback which causes a compilation failure due to type incompatibility. Fixes #1981
loci-dev
had a problem deploying
to
abseil-cpp-prod
GitHub Actions
Failure
loci-dev
force-pushed
the
main
branch
3 times, most recently
from
3f337f5 to
e94d936
Compare
loci-dev
force-pushed
the
main
branch
3 times, most recently
from
1c2844b to
7abb8d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: abseil/abseil-cpp#2037
Add a platform-specific GetTID() implementation for HaikuOS using Haiku's native find_thread(NULL) API, which returns the current thread's ID. Without this, HaikuOS falls through to the generic pthread_self() fallback which causes a compilation failure due to type incompatibility.
Fixes #1981
Thank you for your contribution to Abseil!
Before submitting this PR, please be sure to read our contributing
guidelines.
If you are a Googler, please also note that it is required that you send us a
Piper CL instead of using the GitHub pull-request process. The code propagation
process will deliver the change to GitHub.