UPSTREAM PR #2546: Remove winnow from gix-actor public API#51
Open
UPSTREAM PR #2546: Remove winnow from gix-actor public API#51
winnow from gix-actor public API#51Conversation
Doing so adds conformity with Git, but also simplifies the parser which now only parse hex-hashes of a single valid length. Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: GitoxideLabs/gitoxide#2546
It's too easy to not detect
winnowupdates as a breaking change, and then make patch releases that break existing builds.More importantly, while at it, remove the notion of parser combinators as I found them hard to maintain, and return to simple imperative cursor-oriented parsers.
Tasks
winnowfromgix-actor(as breaking change) + refackiewgix-configfix Unable to add any repository with fresh install of GitButler on MacOS - Unexpected token error gitbutlerapp/gitbutler#8948gixas v0.83 naturally.gix-actor0.40.1 to unbreak v0.81Benches
It turns out that removing
winnowleads to a simpler but faster parser implementation, and it's probably one that I can maintain as well.gix-config
promising as well