UPSTREAM PR #21344: gfx1151 nwarps, tile sizing to curb VGPR pressure#1342
Open
UPSTREAM PR #21344: gfx1151 nwarps, tile sizing to curb VGPR pressure#1342
Conversation
Co-authored-by: Johannes Gäßler <[email protected]>
|
No meaningful performance changes were detected across 125513 analyzed functions in the following binaries: build.bin.libmtmd.so, build.bin.llama-cvector-generator, build.bin.libllama.so, build.bin.llama-tts, build.bin.llama-bench, build.bin.libggml-base.so, build.bin.libggml-cpu.so, build.bin.libggml.so, build.bin.llama-quantize, build.bin.llama-qwen2vl-cli, build.bin.llama-tokenize, build.bin.llama-gemma3-cli, build.bin.llama-gguf-split, build.bin.llama-llava-cli, build.bin.llama-minicpmv-cli. 💬 Questions? Tag @loci-dev |
245e873 to
d101579
Compare
7638ab4 to
f1b46d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: ggml-org/llama.cpp#21344
Follow up on issue #21284
a. MMQ:
mmq_x_max=48,mmq_y=64,nwarps=4for RDNA3_5 to balance VGPR usage and occupancyb. Note: I took the opportunity for a minor refactor replacing nested ternary operators to improve readability and reduce opportunity for errors (especially after I made a mistake while piling on the ternary operations).
mmvq_parameter_table_idinstead of falling back to RDNA2a. Results in nwraps calculation falling to 1.
1 is more important than 2, but 2 is still helpful on the mmvq paths. And it sets up for future per-quant tuning.
Benchmarks
Built with cmake flags
Before (build 7c7d6ce / 8642)
After (build 955df3551 / 8643)
Speedup
Requirements