[MFA-2038] Unsafe code removal. #112
Conversation
| // digestData.count - 1 will always be >0, because digestData depends on algorythm and can be only 20, 32, or 64. | ||
| let offset = Int(digestData[digestData.count - 1] & 0x0f) | ||
| // offset is always <=15, length is always 4, so prefix will always be within digestData count. | ||
| var hash = digestData.dropFirst(offset).prefix(length).reduce(0, { $0 << 8 | UInt32($1) }) |
There was a problem hiding this comment.
If I'm understanding correctly, what the original code did (from L85 to L89) was roughly the following:
Could you please expand how reducing the data (after excluding the offset) by bit-shifting to the left is equivalent to pointee of start.withMemoryRebound(to: UInt32.self, capacity: 1) { $0 }?
There was a problem hiding this comment.
let value = start.withMemoryRebound(to: UInt32.self, capacity: 1) { $0 }
Here we have start as pointer to array of UInt8. withMemoryRebound interpret this array as single UInt32 number. For example for array of 4 UInt8 [0x12, 0x34, 0x56, 0x78], withMemoryRebound will produce single UInt32: 0x78563412. Which is then converted by constructor UInt32(bigEndian:) to 0x1234567.
.reduce(0, { $0 << 8 | UInt32($1) })
Here on the first iteration we have UInt32 equal to 0. Which is 0x00000000. First we shift it by 8 bytex, which produces the same value and doing OR with first element which is 0x12. resulting in 0x00000012. On the next iteration we shift it by 8 bytes resulting in 0x00001200. After doing OR with the next element 0x34, the result is 0x00001234. By the end of iterations we have 0x12345678, which is equal to result of withMemoryRebound with bigEndian.
There was a problem hiding this comment.
Fantastic, thanks for the clarification!
There was a problem hiding this comment.
we shift it by 8 bytes
I assume you meant 8 bits
|
@Artelas, |
|
@ionutmanolache-okta. Yes, every time I've tried to run tests on iOS 16, I got runtime fatal error. |
|
Greate! When release of new version? :) |
Related to
#105
Removed unsafe code. Adjusted solution to match unit tests by excluding excessive checks.