fix: Remove obsolete warning about cookie-size #2012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
frederikprijck
commented
Mar 31, 2025
| @@ -235,9 +235,6 @@ If you'd like to customize the `user` object to include additional custom claims | |||
| ## Additional changes | |||
|
|
|||
| - By default, v4 is edge-compatible and as such there is no longer a `@auth0/nextjs-auth0/edge` export. | |||
| - Cookie chunking has been removed | |||
| - If the cookie size exceeds the browser limit of 4096 bytes, a warning will be logged | |||
| - To store large session data, please use a [custom data store](https://github.com/auth0/nextjs-auth0/tree/main?tab=readme-ov-file#database-sessions) with a SessionStore implementation | |||
There was a problem hiding this comment.
Also removing this from the migration guide, as this is no longer accurate in the latest version of v4.
frederikprijck
force-pushed
the
fix/remove-cookie-size-warning
branch
2 times, most recently
from
cb1066e to
989d726
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2012 +/- ##
==========================================
- Coverage 74.77% 74.68% -0.09%
==========================================
Files 21 21
Lines 1859 1853 -6
Branches 287 286 -1
==========================================
- Hits 1390 1384 -6
Misses 462 462
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tusharpandey13
previously approved these changes
Apr 1, 2025
frederikprijck
force-pushed
the
fix/remove-cookie-size-warning
branch
from
989d726 to
baeb49b
Compare
tusharpandey13
approved these changes
Apr 1, 2025
|
Currently, if you try to google the warning, nothing comes up, so for the sake of google-ability, the warning is,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the fact that we brought back cookie-chunking, we no longer want to output a warning message when the cookie exceeds the limit in size. Instead, we chunk the cookie in that case.
Additionally, since we added id token back in the session, there is a high chance of users hitting the limit, ending up with chunked cookies, and the fact that they will see an irrelevant warning message.