Skip to content

fix: Ensure to delete cookies when switching from single to chunks and vica versa #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

frederikprijck
Copy link
Member

When we reintroduced cookie chunking in #1975, we did not take into account cleaning up existing cookies:

  • when we switch to chunked cookies, we want to remove the non chunked cookie
  • when we switch back to non chunked cookies, we want to remove the chunked cookies.

Ideally, we would only ever have chunked cookies (with a single chunk when the cookie does not exceed the treshold) as that would simplify things alot.

However, with this PR I am addressing the issue reported in #2009

@frederikprijck frederikprijck requested a review from a team as a code owner March 31, 2025 11:52
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.77%. Comparing base (0d7bfc4) to head (a717b5c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2013      +/-   ##
==========================================
+ Coverage   74.68%   74.77%   +0.08%     
==========================================
  Files          21       21              
  Lines        1853     1859       +6     
  Branches      286      288       +2     
==========================================
+ Hits         1384     1390       +6     
  Misses        462      462              
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tusharpandey13
tusharpandey13 previously approved these changes Apr 1, 2025
tusharpandey13
tusharpandey13 previously approved these changes Apr 1, 2025
@tusharpandey13 tusharpandey13 merged commit 77a5b0c into main Apr 1, 2025
12 checks passed
@tusharpandey13 tusharpandey13 deleted the fix/delete-obsolete-cookies branch April 1, 2025 11:05
@tusharpandey13 tusharpandey13 mentioned this pull request Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants