-
Notifications
You must be signed in to change notification settings - Fork 441
docs: Document noContentProfileResponseWhenUnauthenticated option in V4 migration guide #2431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Document noContentProfileResponseWhenUnauthenticated option in V4 migration guide #2431
Conversation
|
Thank you so much for adding this, and apologies for taking so long to get your change in. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2431 +/- ##
=======================================
Coverage 90.99% 90.99%
=======================================
Files 39 39
Lines 4520 4520
Branches 939 939
=======================================
Hits 4113 4113
Misses 401 401
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We do require commits to be signed in order to merge this PR. Any chance you could sign your commit @jcyling ? |
|
Hi @jcyling, we have a requirement that PR commits must have verified signatures. Can you sign your commit |
…ub.com/jcyling/nextjs-auth0 into v4-migration-profile-no-content-option
9e00f89 to
da567f3
Compare
|
@frederikprijck @tusharpandey13 Appreciate the review! The commits in this PR are signed. If you prefer a cleaner history, I’m happy to rebase to remove the duplicate commits - let me know. |
|
I think that looks good, we can use squash and merge for this PR. |
📋 Changes
Updates the V4 migration guide to add documentation for #2159. The
noContentProfileResponseWhenUnauthenticatedoption allows the V4 profile endpoint to replicate V3 behaviour and return a 204 when logged out instead of a 401 error.📎 References
#2159