import: improve err msg #2242
import: improve err msg #2242
Conversation
Signed-off-by: Kartikay <[email protected]>
| @@ -19,7 +19,7 @@ type CircularImportError struct { | |||
| func importFile(filePath string) (*dslNode, error) { | |||
| schemaBytes, err := os.ReadFile(filePath) | |||
| if err != nil { | |||
| return nil, fmt.Errorf("failed to read schema file: %w", err) | |||
| return nil, fmt.Errorf("failed to read import in schema file: %w", err) | |||
There was a problem hiding this comment.
This is good, but we should also decorate it with the source location information from the source file(s) in which the import was used. It would require tracking them in the import context, but it should be doable.
Something like: failed to read import in schema file: %w; referenced at [...]
|
I think the idea of this was that it'd include the information about where in the source it happened:
I think it'll require turning this error: https://github.com/authzed/spicedb/blob/main/pkg/composableschemadsl/compiler/importer.go#L21-L23 into a WithSourceError like this one: https://github.com/authzed/spicedb/blob/main/pkg/composableschemadsl/compiler/translator.go#L94-L96 and then pulling that change into zed. |
Fixes authzed/zed#463, error now explicitly reports that there is something wrong with the import