[virsh metadata] change the checking logic for missing metadata #6376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from libvirt 11.3.0, instead of return status error, libvirt will return an empty string if there is no metadata to be returned Added a new parameter 'metadata_empty' for the negative test cases. This parameter is used to verify that the metadata were not altered by the preceding command. refer to https://gitlab.com/libvirt/libvirt/-/commit/312088d9b62334c950310f369b2e0fe2302a74a3 --- tools: virsh: metadata: do not report error on missing metadata Signed-off-by: zhentang-tz <[email protected]>
|
hi @smitterl , could you help review this pr? Thanks. |
smitterl
requested changes
Jun 17, 2025
| @@ -110,6 +111,10 @@ def get_metadata(metadata_option=""): | |||
| **virsh_dargs) | |||
| check_result(result, status_error) | |||
| # Get metadata | |||
| # from libvirt 11.3.0, instead of return status error, libvirt will return an empty string if there is no metadata to be returned | |||
There was a problem hiding this comment.
Please remove this comment in favor of cleaner code, the information is available in your commit message.
| @@ -137,6 +142,6 @@ def get_metadata(metadata_option=""): | |||
| check_result(result, status_error) | |||
| # Get metadata again | |||
| for option in metadata_option.split(): | |||
| check_result(get_metadata(metadata_option=option), True) | |||
| check_result(get_metadata(metadata_option=option), False, '') | |||
There was a problem hiding this comment.
Will negative scenarios now fail for previous libvirt versions? If so, maybe the negative scenarios should only be run with 11.3.0 or later. This can be achieved by using version switch as described here: https://github.com/autotest/tp-libvirt/blob/master/tp-libvirt_review_comment_summary.rst?plain=1#L121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from libvirt 11.3.0, instead of return status error, libvirt will return an empty string if there is no metadata to be returned Added a new parameter 'metadata_empty' for the negative test cases. This parameter is used to verify that the metadata were not altered by the preceding command.
refer to
https://gitlab.com/libvirt/libvirt/-/commit/312088d9b62334c950310f369b2e0fe2302a74a3 --- tools: virsh: metadata: do not report error on missing metadata