Skip to content

Improve tls_reverse test to use specific machine type #6409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve tls_reverse test to use specific machine type #6409

wants to merge 1 commit into from

Conversation

hholoubk
Copy link
Contributor

@hholoubk hholoubk commented Jun 26, 2025 •
edited
Loading

The test script for tls_reverse was failing, because there is in used in VM xml machine_type based on inner variable machine type - but in this case the VM cannot be started.

With correct type the test will pass - and as it is not about the machine type., I believe it is ok to use general one

@hholoubk hholoubk force-pushed the XXX-94890-tls-reverse-specific-machine-type branch 2 times, most recently from 82ec250 to 3618f0e Compare June 26, 2025 11:59
@hholoubk
Improve test script so it will use in tls_reverse testcase specific m…
d204fca 
…achine_type.

The test was failing for aarch64 - as it need other machine type used in vm xml.

as there was already similar approach for ppc64 machines, I've unified the way, how it is set.
@hholoubk hholoubk force-pushed the XXX-94890-tls-reverse-specific-machine-type branch from 3618f0e to d204fca Compare June 26, 2025 12:02
@hholoubk hholoubk changed the title a Improve tls_reverse test to use specific machine type Jun 26, 2025
@hholoubk hholoubk marked this pull request as ready for review June 26, 2025 12:37
@hholoubk
Copy link
Contributor Author

TEsts passed on ampere-mtsnow-altramax
JOB LOG : /var/log/avocado/job-results/job-2025-06-26T07.46-1c44a05/job.log
(1/2) type_specific.io-github-autotest-libvirt.virsh.migrate_vm.positive_testing.p2p_migration.basic.with_tls_reverse.with_postcopy: STARTED
(1/2) type_specific.io-github-autotest-libvirt.virsh.migrate_vm.positive_testing.p2p_migration.basic.with_tls_reverse.with_postcopy: PASS (178.04 s)
(2/2) type_specific.io-github-autotest-libvirt.virsh.migrate_vm.positive_testing.p2p_migration.basic.with_tls_reverse.without_postcopy: STARTED
(2/2) type_specific.io-github-autotest-libvirt.virsh.migrate_vm.positive_testing.p2p_migration.basic.with_tls_reverse.without_postcopy: PASS (179.67 s)
RESULTS : PASS 2 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

@hholoubk
Copy link
Contributor Author

@dzhengfy could you please review this change. thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hholoubk