-
Notifications
You must be signed in to change notification settings - Fork 182
AMD SNP attestation test enhancement #4351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
565c550
to
8519b16
Compare
@zixi-chen @JinLiul request your review comments. |
Hello I will be happy to address any review comments with respect to this PR. Thank you in advance :) |
d988a61
to
014f9f0
Compare
Hello @bssrikanth, I just came back from holidays this week. |
1. Update snpguest fetch commands to align with recent upstream snpguest tool changes. 2. Improve error handling. Signed-off-by: Srikanth Aithal <[email protected]>
Add script to install snpguest tool from source. It supports customizable repository, branch, or tag, validates inputs, installs dependencies for Ubuntu/Debian or RHEL-based OS, and builds and installs snpguest. Signed-off-by: Srikanth Aithal <[email protected]>
014f9f0
to
d7a5174
Compare
@zixi-chen Thank you for the review comments.
|
1. Update SEV-SNP testcase and config to support snpguest tool installation from source. 2. Enhance CPU model detection for broader platform support. 3. Update SNP policy values, add a debug policy variant 4. Improve error handling in the testcase script. 5. Add snp_attestation.cfg to include newly introduced parameters. Signed-off-by: Srikanth Aithal <[email protected]>
d7a5174
to
5754589
Compare
The current dict_cpu implementation is incompatible with Turin systems and causes failures. The updated version in this patch resolves this issue and the test case pass in Turin. |
@zixi-chen please let me know any comments on the revised version. Happy to address them :) |
This patch introduces improvements to the SEV-SNP attestation workflow.
The changes include a new script for installing the snpguest tool from source,
updates to the attestation workflow to align with upstream changes, and
enhancements to the testcase and configuration files.
Specifically, the series:
Signed-off-by: Srikanth Aithal [email protected]