ci: attribute star history commits to the bot - #734
Merged
Conversation
A plain amend keeps the seed commit's author and author date, so every published refresh read as authored by whoever seeded the branch, on the day they seeded it, however long ago that was. Closes #733
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Published chart commits are attributed to the wrong person. The current tip of
assets, written by the workflow earlier today:git commit --amendpreserves the original author and author date, so the botidentity configured just above it only ever reaches the committer field. Since
the branch is amended in place forever, the author date is pinned to the
seeding and never moves again.
Closes #733
Changes
--reset-authoron the amend, so the bot is recorded as both author andcommitter with the current timestamp.
Testing
Simulated against a real shallow clone of
assets, since the publish path onlyruns when the chart actually changes and the live count currently matches what
is published:
The amended commit stays parentless (
parents=[]), so the orphan branch keepsthe property the
--force-with-leasepush relies on.actionlintclean. This will not be visible until the next refresh thatactually changes the chart, which means the next star.
Type of Change
fix:)feat:)refactor:)docs:)ci:)chore:)Checklist
Closes #Ntype:*and onepriority:*labelphase:*label (or none when not roadmap work)feat/<slug>,fix/<slug>, etc.)mypy src/) — N/A, no Python changedruff check .) — N/A, no Python changedruff format --check .) — N/A, no Python changed