This repository was archived by the owner on Dec 16, 2025. It is now read-only.
chore(core/types): remove Blocks's Timestamp() method
#1429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/block-remove-timestamp
branch
3 times, most recently
from
1bc820a to
2cf8ef3
Compare
darioush
reviewed
Jan 23, 2025
qdm12
force-pushed
the
qdm12/block-remove-timestamp
branch
2 times, most recently
from
29c0766 to
d590a04
Compare
ceyonur
reviewed
Jan 31, 2025
Collaborator
ceyonur
left a comment
ceyonur
left a comment
There was a problem hiding this comment.
changes in the subnet-evm context are lgtm, but we should consider that this will break all precompiles (including precompiles in precompile-evm + subnet-evm forks)
qdm12
force-pushed
the
qdm12/block-remove-timestamp
branch
from
d590a04 to
40167aa
Compare
qdm12
force-pushed
the
qdm12/block-remove-timestamp
branch
from
40167aa to
a0857ed
Compare
- `Time()` does the same as `Timestamp()` - `Time()` is present upstream, not `Timestamp()`
qdm12
force-pushed
the
qdm12/block-remove-timestamp
branch
from
a0857ed to
40e07af
Compare
ceyonur
reviewed
Feb 6, 2025
ceyonur
previously approved these changes
Feb 6, 2025
qdm12
force-pushed
the
qdm12/block-remove-timestamp
branch
from
2b90a54 to
7a882f9
Compare
qdm12
commented
Feb 6, 2025
ceyonur
previously approved these changes
Feb 6, 2025
darioush
reviewed
Feb 6, 2025
darioush
approved these changes
Feb 7, 2025
ceyonur
approved these changes
Feb 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
In
core/types, theBlockmethodTimestampdoes the same as the methodTimeand is not present upstream, this causes small difficulties migrating to libevm core/types.Block which doesn't have a Timestamp method.How this works
core/types.BlockmethodTimestamp()removedcore.NewBlockContextto converttypes.Blockandtypes.Headerfor calls tocore.ApplyUpgradesHow this was tested
Existing CI passing
Need to be documented?
No
Need to update RELEASES.md?
No