Fix bug and add required meta tag #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VastBlast great work. I manually added the missing meta tag after looking through this issue thread. Your fix in 460b6ca would have saved me a lot of time! |
|
@avadhesh18 do you plan to merge this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3 for all devices since iPhone 11.
The logic added will not break the code for any older devices, so it will only help. Although hard coding a ratio isn't perfect, it seems to be the only method to detect the height in private mode, as of now, and all devices since iPhone 11 have been using this ratio.
This PR also automatically adds the
apple-mobile-web-app-capableif not already present, which is a required meta tag for the splash screen.