Skip to content

Conversation

mechite
Copy link
Contributor

@mechite mechite commented Oct 6, 2025

Do not merge

(see #647)

@mechite mechite changed the title add test for JEP 367 support add JEP 367 support Oct 6, 2025
@xabolcs
Copy link

xabolcs commented Oct 6, 2025

Do not merge

"Still in progress? Convert to draft!" 😉

@SentryMan SentryMan marked this pull request as draft October 6, 2025 13:54
@mechite
Copy link
Contributor Author

mechite commented Oct 6, 2025

Do not merge

"Still in progress? Convert to draft!" 😉

Interesting.
sorry, I'm really not used to GitHub at all :/ you learn something new every day
a draft to me is when the subject line contains RFC 😆

new PrintWriter(System.out),
null,
null,
List.of("--release=11", "-AdisableDirectWrites=true"),
Copy link
Collaborator

@SentryMan SentryMan Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set compiler to release 23 minimum if you want markdown

Copy link
Contributor Author

@mechite mechite Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can go ahead and change that - if you can get this test passing, I think it's good to have?
Up to you whether you think it's good to have a direct test for markdown

also, there is a direct copy of this (non-markdown one) in tests for sigma generation etc too

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the method we use to get the javadoc is the same for both non markdown and markdown so I don't really see the point

@SentryMan SentryMan closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants