fix: show TGEAPCET OU region disclaimer on home page before submission - #300
Open
A-Chronicle wants to merge 1 commit into
Open
fix: show TGEAPCET OU region disclaimer on home page before submission#300A-Chronicle wants to merge 1 commit into
A-Chronicle wants to merge 1 commit into
Conversation
A-Chronicle
force-pushed
the
fix/tgeapcet-ou-disclaimer
branch
from
May 25, 2026 15:41
2a66bf2 to
24f23bf
Compare
Signed-off-by: A-Chronicle <chaubeyanshika319@gmail.com>
A-Chronicle
force-pushed
the
fix/tgeapcet-ou-disclaimer
branch
from
May 25, 2026 15:43
24f23bf to
1b71e0d
Compare
Contributor
|
Review note for Amogh / maintainers: This PR is trying to solve the same real issue as #299: TGEAPCET OU-region students should see the data limitation warning before submitting the form. Recommendation: do not merge both #299 and #300. Pick one implementation, or make a fresh minimal PR. This PR also includes unrelated formatting/no-op changes outside the actual product fix, so it is not clean as-is. Product decision is straightforward: the home page should show the OU warning just like the results page already does. Engineering cleanup needed: keep the diff limited to the relevant disclaimer logic in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a student selects TGEAPCET with OU region on the home page, no warning appears about limited OU-specific data. The disclaimer only shows after submission on the results page. This fix mirrors the existing EWS category disclaimer logic to also show when OU region is selected.
Before: Disclaimer only showed for EWS category
After: Disclaimer shows for both EWS category and OU region selection
Fixes #298
Checklist