Skip to content

fix: show TGEAPCET OU region disclaimer on home page before submission - #300

Open
A-Chronicle wants to merge 1 commit into
avantifellows:mainfrom
A-Chronicle:fix/tgeapcet-ou-disclaimer
Open

fix: show TGEAPCET OU region disclaimer on home page before submission#300
A-Chronicle wants to merge 1 commit into
avantifellows:mainfrom
A-Chronicle:fix/tgeapcet-ou-disclaimer

Conversation

@A-Chronicle

Copy link
Copy Markdown

Description

When a student selects TGEAPCET with OU region on the home page, no warning appears about limited OU-specific data. The disclaimer only shows after submission on the results page. This fix mirrors the existing EWS category disclaimer logic to also show when OU region is selected.

Before: Disclaimer only showed for EWS category
After: Disclaimer shows for both EWS category and OU region selection

Fixes #298

Checklist

  • Small, focused correctness fix with clear before/after behavior
  • Zero breaking changes
  • Follows existing code patterns (same disclaimer component, same styling)

@A-Chronicle
A-Chronicle force-pushed the fix/tgeapcet-ou-disclaimer branch from 2a66bf2 to 24f23bf Compare May 25, 2026 15:41
Signed-off-by: A-Chronicle <chaubeyanshika319@gmail.com>
@A-Chronicle
A-Chronicle force-pushed the fix/tgeapcet-ou-disclaimer branch from 24f23bf to 1b71e0d Compare May 25, 2026 15:43
@suryabulusu

Copy link
Copy Markdown
Contributor

Review note for Amogh / maintainers:

This PR is trying to solve the same real issue as #299: TGEAPCET OU-region students should see the data limitation warning before submitting the form.

Recommendation: do not merge both #299 and #300. Pick one implementation, or make a fresh minimal PR. This PR also includes unrelated formatting/no-op changes outside the actual product fix, so it is not clean as-is.

Product decision is straightforward: the home page should show the OU warning just like the results page already does. Engineering cleanup needed: keep the diff limited to the relevant disclaimer logic in pages/index.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: TGEAPCET OU region data limitation disclaimer is missing on the home page

2 participants