Ability to pass more information to callbacks. #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe, there is better solution than creating Breaking change. For instance new interface with extras method argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key changes:
int requestCodereplaced byBaseDialogFragment dialog.BaseDialogBuilder.setExtras(Bundle).BaseDialogFragment.getRequestCode().You can now handle more information about dialog in callbacks. For example you ask user to confirm delete item from list. Now you can pass item id in extras and then get it from
dialog.getArguments().getBundle(BaseDialogBuilder.ARG_EXTRAS).