Skip to content

Transform => into -> (lenient-parser) 🏹 #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

kutyel
Copy link
Contributor

@kutyel kutyel commented Mar 15, 2023

Apparently some JS/Elm developers hit this case frequently, so it was worth a shot (let me know if you do not consider this contribution useful 🙏🏻 ).

Also sorry for a little noise but I was mostly addressing hlint recommendations for refactor/simplifications 😉

@avh4 avh4 added this to the 0.8.7 milestone Mar 15, 2023
avh4
avh4 previously requested changes Mar 15, 2023
Copy link
Owner

@avh4 avh4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with some hlint changes, but I'm not ready to accept broad formatting changes for the haskell code right now, sorry!

Would you mind trying this for function types too?

foo : Int => Int => Int => Int

@kutyel kutyel force-pushed the lenient-paser/transform-fat-arrow branch from 4dd70f0 to 2711d85 Compare March 15, 2023 20:14
@kutyel kutyel requested a review from avh4 March 15, 2023 20:15
@avh4
Copy link
Owner

avh4 commented Mar 16, 2023

Ah, so that change is in rightArrow, which affects multiple places.

Just checking where else that affects to make sure it seems safe...

  • lambda expressions: it immediately follows a Pattern
  • function types: it immediately follows a Type
  • case branches: it immediately follows a Pattern

Since = has no valid meaning in Types and Patterns, I guess this should be safe 👍

@avh4 avh4 merged commit 57c12ea into avh4:main Mar 16, 2023
@avh4
Copy link
Owner

avh4 commented Mar 16, 2023

Thanks!

@kutyel kutyel deleted the lenient-paser/transform-fat-arrow branch March 16, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants