Conversation
|
The delay is something we should fix, but the downside with this approach is that reading Perhaps the fix would instead be to simply reset delta time when physics is paused (like before), and to only advance the simulation when it is not paused. This breaks the old supported approach of manually advancing |
|
Although, I suppose manual stepping like that is not necessarily as simple as "just run |
|
Hmmm yeah I don't really the idea of manually advancing a paused clock to continue the simulation. IMO If users want to have manual control over My main point here is that it could be cleaner to leave But I'm out of my element here, as I said I'm not a user of the manual simulation API. |
|
Related: #661 |
Fixes #776. Details available on the issue.
Summary: currently if the user pauses
Time<Physics>the pause is delayed by 1 frame because we detect the delta time of the previous frame as if the user had manually advanced the clock. This PR fixed the issue by always resetting the delta time. This shouldn't cause regressions since it doesn't interfere with the 2 standard ways to advance the simulation on the next frame: if the clock is not paused then the delta time will be automatically set at the beginning ofrun_physics_scheduleand if the user manually advances the time then the reset will get overridden.