Skip to content

Add support for windows new architecture#295

Open
tux2nicolae wants to merge 1 commit into
avishayil:masterfrom
crisposoft:master
Open

Add support for windows new architecture#295
tux2nicolae wants to merge 1 commit into
avishayil:masterfrom
crisposoft:master

Conversation

@tux2nicolae

Copy link
Copy Markdown

This pull request improves Windows (react-native-windows) support for the package, including new codegen configuration.

@tux2nicolae

Copy link
Copy Markdown
Author

@avishayil can you check this one please.

This PR only affects windows support which in fact is already broken.

What actually I did different from the old implementation is that the old windows support fully restarted the app instead of only the react native host.

void RNRestart::loadBundle() noexcept {
  auto host = Microsoft::ReactNative::ReactNativeHost::FromContext(m_context.Handle());
  if (host) {
    host.ReloadInstance();
  }
}

The windows support is needed as a prerequisite for this PR on react-native-screens (which depends on react-native-restart) to have a complete implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant