Skip to content

chore: Add convention plugins for Android Libraries #3082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 29, 2025

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
This PR moves build logic into convention plugins located in a build-logic subproject. The goal is to make our build system easier to maintain over time.

Not all functionality has been moved. Specifically remaining:

  • checkstyle
  • maven publishing

How did you test these changes?

  • Builds execute as normal

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(storage): message, feat(auth): message, chore(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner June 26, 2025 19:54
tylerjroach
tylerjroach previously approved these changes Jun 26, 2025
@mattcreaser mattcreaser force-pushed the mattcreaser/build-logic branch from dbf59e4 to da67d41 Compare July 28, 2025 19:47
@mattcreaser mattcreaser force-pushed the mattcreaser/build-logic branch from 2819477 to cdd80d6 Compare July 29, 2025 15:43
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.22%. Comparing base (37a62ed) to head (fdaefef).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3082      +/-   ##
==========================================
- Coverage   54.24%   54.22%   -0.02%     
==========================================
  Files        1038     1038              
  Lines       31991    31991              
  Branches     4702     4702              
==========================================
- Hits        17354    17348       -6     
- Misses      12789    12796       +7     
+ Partials     1848     1847       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattcreaser mattcreaser merged commit d274d3e into main Jul 29, 2025
15 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/build-logic branch July 29, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants