remove stacks in error stack

aws-amplify · Feb 18, 2025 · 38e3dd3 · 38e3dd3
1 parent 2a08ebf
commit 38e3dd3
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/packages/platform-core/src/telemetry-data/serializable_error.test.ts b/packages/platform-core/src/telemetry-data/serializable_error.test.ts
@@ -124,4 +124,17 @@ void describe('serializable error', () => {
       `${expectedFilePath} is not found in ${serializableError.stack}`
     );
   });
+
+  void test('that error stack does not contain stacks', () => {
+    const error = new Error('test error');
+    error.stack =
+      'Stack with id amplify-test-stack-sandbox-12345abcde does not exist';
+    const serializableError = new SerializableError(error);
+    assert.ok(
+      serializableError.stack.includes(
+        'Stack with id <escaped stack> does not exist'
+      ),
+      `Stack is not removed in ${serializableError.stack}`
+    );
+  });
 });
diff --git a/packages/platform-core/src/telemetry-data/serializable_error.ts b/packages/platform-core/src/telemetry-data/serializable_error.ts
@@ -30,7 +30,9 @@ export class SerializableError {
         ? this.sanitize(error.code as string)
         : error.name;
     this.message = this.anonymizePaths(this.sanitize(error.message));
-    this.stack = this.anonymizePaths(error.stack ?? '');
+    this.stack = error.stack
+      ? this.anonymizePaths(this.sanitize(error.stack))
+      : '';
   }
 
   private anonymizePaths = (str: string): string => {