Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump @typescript-eslint/eslint-plugin from 6.21.0 to 8.23.0 #2478

Merged
merged 8 commits into from
Feb 12, 2025
Merged

chore(deps-dev): bump @typescript-eslint/eslint-plugin from 6.21.0 to 8.23.0 #2478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3e94278
chore(deps-dev): bump @typescript-eslint/eslint-plugin
dependabot[bot] Feb 3, 2025
7c638b1
make code new eslint compliant
Amplifiyer Feb 7, 2025
58d61da
update changeset
Amplifiyer Feb 7, 2025
caaf24a
increase max old space size
rtpascual Feb 10, 2025
96d5dc5
increase max old space size
rtpascual Feb 10, 2025
c9ca2c8
add checkJs compiler option
rtpascual Feb 10, 2025
0611b22
try this
rtpascual Feb 10, 2025
0b71e57
bump ci
rtpascual Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changeset/small-camels-eat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
'@aws-amplify/backend-deployer': patch
'@aws-amplify/backend-function': patch
'@aws-amplify/form-generator': patch
'@aws-amplify/ai-constructs': patch
'@aws-amplify/platform-core': patch
'@aws-amplify/cli-core': patch
'@aws-amplify/backend-cli': patch
---

Update code with Eslint@8 compliant
13 changes: 12 additions & 1 deletion .eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,18 @@ module.exports = {
},
],
'@typescript-eslint/method-signature-style': 'error',
'@typescript-eslint/switch-exhaustiveness-check': 'error',
'@typescript-eslint/switch-exhaustiveness-check': [
'error',
{
considerDefaultExhaustiveForUnions: true,
},
],
'@typescript-eslint/no-unused-expressions': [
'error',
{
allowShortCircuit: true,
},
],
'@typescript-eslint/no-floating-promises': 'error',
'@typescript-eslint/no-misused-promises': 'error',
'@typescript-eslint/parameter-properties': [
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/health_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,10 @@ jobs:
node-version: 18
cdk-version: ${{ needs.resolve_inputs.outputs.cdk_version }}
- run: npm run lint
env:
# increase v8's old memory section max size to ~15.5 GB
# see https://nodejs.org/api/cli.html#--max-old-space-sizesize-in-megabytes
NODE_OPTIONS: '--max-old-space-size=14782'
Comment on lines +612 to +615
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative to this that I found is to switch our eslint parser options to use projectService instead of project, see https://typescript-eslint.io/packages/parser/#project. Only thing is projectService doesn't seem to follow tsconfig.json exclude setting so I think we have to ignore typescript files excluded by any tsconfig

check_dependencies:
runs-on: ubuntu-latest
needs:
Expand Down
Loading
Loading