-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
paginate getParameter call when there are more than 10 parameters #2480
Conversation
🦋 Changeset detectedLatest commit: cf70f40 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious how easily we can hit the limit of the Lambda's Init
phase of 10 seconds. Would you need to max out the function's env vars to 4KB and have the max amount of extensions added as layers? (This is only a question, not blocking this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this file since the code is included and tested for in the shims.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I forgot to remove it earlier. Removed it in new revision
I haven't tested what would break the limit of the |
Problem
when using defineFunction with more than 10 secrets, the SDK call fails to resolve due to a validation on the
Names
argIssue number, if available: #2413
Changes
Paginate the request to call
getParameters
with 10 parameters at a time.Corresponding docs PR, if applicable:
Validation
Unit tests and manual validation
Checklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.