-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cdk checks #2520
fix cdk checks #2520
Conversation
|
npm install --no-save aws-cdk-lib@${{ inputs.cdk-lib-version }} | ||
fi | ||
if [[ ${{ inputs.cdk-cli-version }} != 'FROM_PACKAGE_LOCK' ]]; then | ||
echo "Installing CDK Lib version ${{ inputs.cdk-cli-version }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be "Installing CDK CLI version" right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, that's copy-paste error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem
The CDK Lib and CLI versions has diverged. This is expected activity on CDK side. See aws/aws-cdk#32775
Issue number, if available:
Changes
Decouple CDK Lib and CLI versions in applicable places.
Validation
Checklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.