Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cdk checks #2520

Merged
merged 5 commits into from
Feb 18, 2025
Merged

fix cdk checks #2520

merged 5 commits into from
Feb 18, 2025

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Feb 18, 2025

Problem

The CDK Lib and CLI versions has diverged. This is expected activity on CDK side. See aws/aws-cdk#32775

Issue number, if available:

Changes

Decouple CDK Lib and CLI versions in applicable places.

Validation

  1. PR checks with e2e tests
  2. CDK validation workflow https://github.com/aws-amplify/amplify-backend/actions/runs/13401031668
  3. Canaries https://github.com/aws-amplify/amplify-backend/actions/runs/13401039296

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk added the run-e2e Label that will include e2e tests in PR checks workflow label Feb 18, 2025
Copy link

changeset-bot bot commented Feb 18, 2025

⚠️ No Changeset found

Latest commit: 5966579

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sobolk sobolk marked this pull request as ready for review February 18, 2025 22:20
@sobolk sobolk requested review from a team as code owners February 18, 2025 22:20
@sobolk sobolk merged commit f498280 into main Feb 18, 2025
139 checks passed
@sobolk sobolk deleted the fix-cdk-checks branch February 18, 2025 23:53
npm install --no-save aws-cdk-lib@${{ inputs.cdk-lib-version }}
fi
if [[ ${{ inputs.cdk-cli-version }} != 'FROM_PACKAGE_LOCK' ]]; then
echo "Installing CDK Lib version ${{ inputs.cdk-cli-version }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "Installing CDK CLI version" right

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, that's copy-paste error.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e Label that will include e2e tests in PR checks workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants