feat: add ddb deletion protection on imported tables

packages/amplify-graphql-api-construct-tests/src/commands.ts

@@ -11,7 +11,7 @@ import {
   sleep,
   updateApiSchema,
 } from 'amplify-category-api-e2e-core';
-import { DynamoDBClient, DeleteTableCommand, ListTablesCommand } from '@aws-sdk/client-dynamodb';
+import { DynamoDBClient, DeleteTableCommand, ListTablesCommand, UpdateTableCommand } from '@aws-sdk/client-dynamodb';
 
 /**
  * Retrieve the path to the `npx` executable for interacting with the aws-cdk cli.
@@ -215,6 +215,7 @@ export const createGen1ProjectForMigration = async (
 
   // TODO: GEN1_GEN2_MIGRATION
   // Construct the DataSourceMappingOutput with the AWS SDK
+  // Set table deletion protection to true for all tables
   // Remove this block when the feature flag is released
   // Start block
   const client = new DynamoDBClient({ region: process.env.CLI_REGION || 'us-west-2' });
@@ -226,12 +227,19 @@ export const createGen1ProjectForMigration = async (
     ExclusiveStartTableName = response.LastEvaluatedTableName;
     tables.push(...response.TableNames);
   } while (ExclusiveStartTableName);
-  const tableNameMapping = tables
+  const tablesForApi = tables
     // filter all tables by the API ID
-    .filter((tableName) => tableName.includes(GraphQLAPIIdOutput))
+    .filter((tableName) => tableName.includes(GraphQLAPIIdOutput));
+
+  const tableNameMapping = tablesForApi
     // extract the model name from the table name and create the mapping
     .map((tableName) => [tableName.match(/(^.*?)-/)[1], tableName]);
   const DataSourceMappingOutput = JSON.stringify(Object.fromEntries(tableNameMapping));
+
+  // set deletion protection to true for all tables
+  await Promise.allSettled(
+    tablesForApi.map((tableName) => client.send(new UpdateTableCommand({ TableName: tableName, DeletionProtectionEnabled: true }))),
+  );
   // End block
 
   return {
@@ -248,5 +256,9 @@ export const createGen1ProjectForMigration = async (
  */
 export const deleteDDBTables = async (tableNames: string[]): Promise<void> => {
   const client = new DynamoDBClient({ region: process.env.CLI_REGION || 'us-west-2' });
+  // disable deletion protection before deleting the tables
+  await Promise.allSettled(
+    tableNames.map((tableName) => client.send(new UpdateTableCommand({ TableName: tableName, DeletionProtectionEnabled: false }))),
+  );
   await Promise.allSettled(tableNames.map((tableName) => client.send(new DeleteTableCommand({ TableName: tableName }))));
 };

packages/amplify-graphql-model-transformer/src/__tests__/amplify-dynamodb-table-generator.test.ts

@@ -72,6 +72,7 @@ describe('ModelTransformer:', () => {
     expect(authorTable.DeletionPolicy).toBe('Retain');
     expect(authorTable.Properties.isImported).toBe(true);
     expect(authorTable.Properties.tableName).toBe('Author-myApiId-myEnv');
+    expect(authorTable.Properties.deletionProtectionEnabled).toBe(true);
     validateModelSchema(parse(out.schema));
 
     // Outputs should contain a reference to the Arn to the entry point (onEventHandler)

packages/amplify-graphql-model-transformer/src/resources/amplify-dynamodb-table/amplify-dynamo-model-resource-generator.ts

@@ -204,6 +204,7 @@ export class AmplifyDynamoModelResourceGenerator extends DynamoModelResourceGene
       stream: StreamViewType.NEW_AND_OLD_IMAGES,
       encryption: TableEncryption.DEFAULT,
       removalPolicy,
+      deletionProtection: isTableImported,
       ...(context.isProjectUsingDataStore() ? { timeToLiveAttribute: '_ttl' } : undefined),
       ...(isTableImported ? { isImported: true } : undefined),
     });