Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-schema): add authorization to custom type #530

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pavinthan
Copy link

@pavinthan pavinthan commented Feb 21, 2025

Allow authorization of custom type, custom type can be use with authorization.

Problem

Currently custom types permission depends on

  1. Model fields authorization
  2. Custom operations authorization

Currently custom operation doesn't support all authorization but types can supports most of the authorization directives.

Issues

customType references aren't align with authorization policies

Changes

Custom types can have authorization directives, so lets add authorization to custom type.

Corresponding docs PR, if applicable:

a.customType({}).authorization((allow) => [
     allow.guest(),
     allow.publicApiKey(),
     allow.authenticated(),
])

Validation

E2E tests

Checklist

  • If this PR includes a functional change to the runtime or type-level behavior of the code, I have added or updated automated test coverage for this change. (see Testing Strategy README)
  • If this PR requires a docs update, I have linked to that docs PR above.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pavinthan pavinthan requested a review from a team as a code owner February 21, 2025 19:11
Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: 770ba6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant