fix: fix bug with missing arrays and requireds in custom operation args #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guments Fixes issue aws-amplify#546 in which arguments to custom operations would ignore arrays and requireds in both the arguments themselves and in the fields of custom types used as arguments. This adds a bunch of tests to verify the schema output matches expectations and the code changes required to fix the bug.
🦋 Changeset detectedLatest commit: 534ee24 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes issue #546 in which arguments to custom operations would ignore arrays and requireds in both the arguments themselves and in the fields of custom types used as arguments.
Issue number: #546
Changes
The code that adds the square brackets and exclamation marks is copied and pasted. I had considered abstracting this into a separate function, however there are a number of locations throughout
SchemaProcessor.tswhere this code is repeated, so I decided to keep it consistent.Validation
I've added a number of unit tests to cover pretty much all combinations of objects/enums/arrays/required. (Perhaps too many?)
I wasn't sure that this was the best file to add the tests to. Please let me know if you'd like this changed.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.