chore: add DS integ test for parent ID query #1694
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1694 +/- ##
==========================================
+ Coverage 42.53% 42.54% +0.01%
==========================================
Files 376 375 -1
Lines 10866 10863 -3
==========================================
Hits 4622 4622
+ Misses 6244 6241 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
HuiSF
approved these changes
Jun 8, 2022
Comment on lines
+105
to
+107
| expect(posts.contains(testPost1), isTrue); | ||
| expect(posts.contains(testPost2), isTrue); | ||
| expect(posts.contains(testPost3), isFalse); |
There was a problem hiding this comment.
nit:
Suggested change
| expect(posts.contains(testPost1), isTrue); | |
| expect(posts.contains(testPost2), isTrue); | |
| expect(posts.contains(testPost3), isFalse); | |
| expect(posts, containsAll([testPost1, testPost2])); | |
| expect(posts, isNot(contains(testPost3))); |
|
@Jordan-Nelson can this be closed or should it be reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.