fix: next request check for serverless environments #14466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soberm
requested review from
pranavosu,
sobolk,
Amplifiyer and
avi-karthik
as code owners
adrianjoshua-strutt
approved these changes
Jul 17, 2025
Simone319
approved these changes
Jul 17, 2025
pranavosu
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The instanceof Request type guard check fails in AWS Lambda environments (specifically with OpenNext/SST
deployments). The problem causes authentication API routes to work on cold Lambda starts but fail on subsequent warm invocations with a 500 error: "Invalid request and context/response
combination. The request cannot be handled." This PR changes the check to use duck typing to prevent possible constructor references to differ between invocations.
Issue #, if available
14455
Description of how you validated changes
** Failing tests unrelated
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.