Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWSGoogleSignIn upgrade to GoogleSignIn 8.0.0 #5502

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

AWSGoogleSignIn upgrade to GoogleSignIn 8.0.0 #5502

wants to merge 1 commit into from

Conversation

BillBunting
Copy link
Contributor

Issue #, if available: #4827

Description of changes:
Upgrade AWSGoogleSignIn to use GoogleSignIn version 8.0.0 (was 5.x.x)

  • GoogleSignIn no longer uses GIDSignInDelegate
  • Copied in headers from GoogleSignIn as needed following the existing code pattern.
  • GoogleSignIn does not support setting scopes prior to authentication, scopes support removed (unnecessary)
  • updated code as necessary and deleted unused legacy code
  • Added s.dependency 'GoogleSignIn', '8.0.0' to podspec

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@BillBunting BillBunting requested review from awsmobilesdk and a team as code owners February 2, 2025 22:49
Cezarsilvasantosotaner
Cezarsilvasantosotaner reviewed Mar 8, 2025
View reviewed changes
Copy link

@Cezarsilvasantosotaner Cezarsilvasantosotaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flatpak run com.valvesoftware.SteamLink

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cezarsilvasantosotaner Cezarsilvasantosotaner Cezarsilvasantosotaner left review comments

@awsmobilesdk awsmobilesdk Awaiting requested review from awsmobilesdk awsmobilesdk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillBunting @Cezarsilvasantosotaner