Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y- Scrollable table is missing role="region" #7943

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

katiegoines
Copy link
Contributor

@katiegoines katiegoines commented Sep 5, 2024

Description of changes:

[Issue]
There are tables present in the below the mentioned sections where they lacks a role region information. Screen reader users will have difficulty determining the purpose and state of these controls.

  • Add caption to tables functionality
  • In MDXTable, add role="region" to the ScrollView
  • use aria-labelledby on the scrollview container to reference the caption element. - there isn't a way to add a prop for caption content so I used the heading the table falls under

staging: https://a11y-scrollable-table.d1egzztxsxq9xz.amplifyapp.com/react/start/migrate-to-gen2/

Ran accessibility tests after changing a page with tables and the tests passed with the role='region' added, which had failed here and why we rolled back this PR
Screenshot 2024-09-05 at 2 49 38 PM

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@katiegoines katiegoines requested a review from a team as a code owner September 5, 2024 20:32
@Modernleadershippizza
Copy link

Thanks for the quick FIX @katiegoines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants