Skip to content

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Oct 6, 2025

Please provide the issue number

Issue number: #1015

Summary

Changes

Add AWS javascript bootstrap to docs

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Oct 6, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 6, 2025
@hjgraca hjgraca linked an issue Oct 6, 2025 that may be closed by this pull request
1 task
@github-actions github-actions bot added the internal Maintenance changes label Oct 6, 2025
@hjgraca hjgraca requested a review from dreamorosi October 6, 2025 14:58
Comment on lines 15 to 19
function copyToClipboard(e) {
e.preventDefault()
navigator.clipboard.writeText(e.target.textContent)
alert$.next("Copied to clipboard")
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to keep this as well as enableClipboardElements, attachListeners, and call it at the end of the file like attachListeners() (where now init() is).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this should be the pull request to copy from https://github.com/aws-powertools/powertools-lambda-typescript/pull/4614/files ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

mkdocs.yml Outdated
site_author: Amazon Web Services
repo_url: https://github.com/aws-powertools/powertools-lambda-dotnet
edit_uri: edit/develop/docs
site_url: https://docs.powertools.aws.dev/lambda/dotnet/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boring-cyborg boring-cyborg bot added area/idempotency area/logging Core logging utility area/metrics Core metrics utility area/parameters area/tracing Core tracing utility github-templates Changes in GitHub issue/PR templates labels Oct 6, 2025
@hjgraca hjgraca requested a review from dreamorosi October 6, 2025 20:14
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.91%. Comparing base (0a5659d) to head (a68967d).
⚠️ Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1016      +/-   ##
===========================================
+ Coverage    77.86%   77.91%   +0.05%     
===========================================
  Files          298      298              
  Lines        11643    11643              
  Branches      1394     1394              
===========================================
+ Hits          9066     9072       +6     
+ Misses        2126     2121       -5     
+ Partials       451      450       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

sonarqubecloud bot commented Oct 6, 2025

@hjgraca hjgraca requested a review from sthulb October 7, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/idempotency area/logging Core logging utility area/metrics Core metrics utility area/parameters area/tracing Core tracing utility documentation Improvements or additions to documentation github-templates Changes in GitHub issue/PR templates internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Add AWS docs bootstrap JavaScript
3 participants