-
Notifications
You must be signed in to change notification settings - Fork 33
chore: add aws docs javascript bootstrap #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
function copyToClipboard(e) { | ||
e.preventDefault() | ||
navigator.clipboard.writeText(e.target.textContent) | ||
alert$.next("Copied to clipboard") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to keep this as well as enableClipboardElements
, attachListeners
, and call it at the end of the file like attachListeners()
(where now init()
is).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this should be the pull request to copy from https://github.com/aws-powertools/powertools-lambda-typescript/pull/4614/files ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
mkdocs.yml
Outdated
site_author: Amazon Web Services | ||
repo_url: https://github.com/aws-powertools/powertools-lambda-dotnet | ||
edit_uri: edit/develop/docs | ||
site_url: https://docs.powertools.aws.dev/lambda/dotnet/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes. @leandrodamascena you need to change in python as well https://github.com/aws-powertools/powertools-lambda-python/blob/develop/mkdocs.yml#L6
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1016 +/- ##
===========================================
+ Coverage 77.86% 77.91% +0.05%
===========================================
Files 298 298
Lines 11643 11643
Branches 1394 1394
===========================================
+ Hits 9066 9072 +6
+ Misses 2126 2121 -5
+ Partials 451 450 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Issue number: #1015
Summary
Changes
Add AWS javascript bootstrap to docs
User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.