-
Notifications
You must be signed in to change notification settings - Fork 167
feat(event-handler): add error handling functionality to BaseRouter #4316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not all issues are linked correctly. Please link each issue to the PR either manually or using a closing keyword in the format If mentioning more than one issue, separate them with commas: i.e. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR - left a few comments
|
Summary
This PR adds error handling logic to the
BaaseRouter
classChanges
BaseRouter
NotFound
andMethodNotAllowed
handlersIssue number: #4141
Final part of the error handling piece is to add support for decorators. I have left that till last because I wanted the logic to be easily reviewable before we added the method overloads and bolierplate to support them.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.