Skip to content

improv(logger): resolve issue when no logger region is set #4319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/logger/src/Logger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1362,6 +1362,7 @@ class Logger extends Utility implements LoggerInterface {
this.addToPowertoolsLogData({
awsRegion: getStringFromEnv({
key: 'AWS_REGION',
defaultValue: '',
}),
environment:
environment ||
Expand Down
44 changes: 44 additions & 0 deletions packages/logger/tests/unit/setPowertoolsLogData.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
import { Logger } from '../../src/Logger.js';
import { describe, it, expect, vi, afterEach } from 'vitest';

describe('Logger PowertoolsLogData environment variables', () => {
afterEach(() => {
vi.unstubAllEnvs();
});

it.each([
[undefined, ''],
['us-west-2', 'us-west-2'],
])('sets awsRegion to %s when AWS_REGION env var is %s', (envValue, expected) => {
// Prepare
vi.stubEnv('AWS_REGION', envValue);
// Act
const logger = new Logger();
// Assess
expect(logger['powertoolsLogData'].awsRegion).toBe(expected);
});

it.each([
[undefined, ''],
['prd', 'prd'],
])('sets environment to %s when ENVIRONMENT env var is %s', (envValue, expected) => {
// Prepare
vi.stubEnv('ENVIRONMENT', envValue);
// Act
const logger = new Logger();
// Assess
expect(logger['powertoolsLogData'].environment).toBe(expected);
});

it.each([
[undefined, 'service_undefined'],
['my-service', 'my-service'],
])('sets serviceName to %s when POWERTOOLS_SERVICE_NAME env var is %s', (envValue, expected) => {
// Prepare
vi.stubEnv('POWERTOOLS_SERVICE_NAME', envValue);
// Act
const logger = new Logger();
// Assess
expect(logger['powertoolsLogData'].serviceName).toBe(expected);
});
});