Skip to content

Fix assessment API drift and stabilize tests#43

Merged
vivekmittal514 merged 3 commits into
aws-samples:mainfrom
agasthik:fix/bedrock-assessment-api-compat-and-perms
Jun 22, 2026
Merged

Fix assessment API drift and stabilize tests#43
vivekmittal514 merged 3 commits into
aws-samples:mainfrom
agasthik:fix/bedrock-assessment-api-compat-and-perms

Conversation

@agasthik

Copy link
Copy Markdown
Contributor

Issue #, if available:
#42

Description of changes:

Summary

This PR fixes Bedrock assessment issues caused by API drift and missing permissions, updates AgentCore checks for current API shapes, and stabilizes the test suite.

Changes

  • Fixed BR-04 false positive by handling Bedrock invocation logging S3 config via bucketName
  • Added missing Bedrock Knowledge Base permissions for BR-09
  • Fixed BR-12 access-denied handling to report COULD NOT ASSESS
  • Patched additional verified Bedrock issues in BR-07 and BR-08
  • Updated AgentCore checks for current response shapes and generic resource policy lookups
  • Fixed FinServ test import shadowing (app / schema / conftest)
  • Added shared test helper modules and cleaned up residual bad patch targets
  • Fixed AgentCore tests that were still leaking to live boto3 clients
  • Cleaned up Ruff findings in touched files

Validation

  • Verified Bedrock behavior against real AWS CLI responses

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@vivekmittal514 vivekmittal514 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran for single and multi account and the reports are fine.

@vivekmittal514 vivekmittal514 merged commit bc2737d into aws-samples:main Jun 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BR-04 False Positive — Wrong S3 config key name + BR-09 Missing IAM Permission

2 participants