Improve security report structure and documentation accuracy#49
Merged
vivekmittal514 merged 3 commits intoJul 10, 2026
Merged
Conversation
Documentation corrections validated against the assessment code: - SECURITY_CHECKS.md: correct SM-04, SM-11 (Medium->High) and AC-07 (High->Medium) severities to match the Failed-path finding severity - SECURITY_CHECKS_FINSERV.md: rewrite the compliance framework mapping table to match the code's COMPLIANCE_MAP (7 of 9 framework rows were out of sync) - DEVELOPER_GUIDE.md: fix Bedrock check count (14->32) and complete the docs tree listing - SECURITY_CHECKS_FINSERV_SEVERITY_METHODOLOGY.md: fix dead relative link to the severity register - README.md: "Risk by Region" -> "Risk by Region / Scope" to match the refactored report heading - finserv app.py / test_severity_register.py: correct severity doc filename references in comments/docstrings Also refresh the sample HTML reports and dashboard screenshots.
vivekmittal514
approved these changes
Jul 10, 2026
vivekmittal514
left a comment
Contributor
There was a problem hiding this comment.
PR #49 Review — "Improve security report structure and documentation accuracy"
Overall: Clean PR. No correctness bugs found. This is a well-executed report-presentation refactor with doc link maintenance. No assessment logic changes.
What works correctly:
Unified #findingsTable with 6 columns — column count consistent across , , and colspan
Filter buttons (data-filter-service + data-filter-status) wire up correctly
scored_findings vs actionable_findings math is preserved
AgentCore app.py changes are URL-only (no assessment logic modified)
CSS widths sum to 100%
All format template placeholders properly supplied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch reworks the interactive HTML report into a single, filterable findings table, refreshes reference documentation links across all assessment modules, and
corrects a set of documentation-accuracy issues found by auditing the docs against the assessment code. No assessment logic or check behavior changes — this is a
report-presentation refactor plus reference-link and documentation maintenance.
What changed
summary card (Failed / Passed / N-A / Total) with "View failed findings" and "View all rows" buttons that filter the shared table.
Details
disclosure ("Details and remediation").applyFilters().
is unchanged).
module-level constants.
source, since these strings ship in each finding's CSV).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.