Fix UI-owned phase transitions and workflow state#252
Open
JWThewes wants to merge 3 commits into
Open
Conversation
jeromevdl
reviewed
Jun 26, 2026
| }); | ||
| return reload(); | ||
| }) | ||
| .catch(() => {}); |
Contributor
There was a problem hiding this comment.
maybe put a console.warn
jeromevdl
reviewed
Jun 26, 2026
| }); | ||
| await reload(); | ||
| const nextPath = getSprintPhasePath(projectId, sprintId, 'COMPLETED'); | ||
| if (nextPath) navigate(nextPath); |
Contributor
There was a problem hiding this comment.
not sure this is useful, as marking COMPLETE would redirect to ReviewPage (on which we are already), furthermore there is the reload just before that does the job...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Phase transitions are UI-owned: users click Approve & Move to Construction, End Construction & Move to Review, or complete review actions. The agent should finish phase work, mark the Sprint ready, summarize, and stop. This avoids duplicate approval modals and orphaned questions while giving both agents and the UI one shared source of truth for workflow position.
What changed
Verification