Skip to content

Clean up legacy ContainerInsights #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Clean up legacy ContainerInsights #1772

wants to merge 10 commits into from

Conversation

movence
Copy link
Contributor

@movence movence commented Jul 11, 2025

Description of the issue

There are dead codes that used to support legacy ContainerInsights.

These functionalities are now supported by the ContainerInsights packages from the contrib

Description of changes

  • Deprecate unused processor packages (k8sdecorator and ecsdecorator)
  • Deprecate related functions and packages (stores under k8sclient, kubeletutil and others)
  • Deprecate internal/containerinsightscommon
    • move consts into internal/constants/containerinsights.go
    • move a function only used by metrictransformerprocessor to prefix metric names by resource type (eg. gpu_utilization -> node_gpu_utilization)

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Validated ContainerInsights and ApplicationSignals working as expected after this clean up

Requirements

Before commiting your code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

Integration Tests

To run integration tests against this PR, add the ready for testing label.

@movence movence requested a review from a team as a code owner July 11, 2025 18:17
@movence movence added the ready for testing Indicates this PR is ready for integration tests to run label Jul 11, 2025
@movence movence changed the title Ci cleanup Clean up legacy ContainerInsights Jul 11, 2025
Copy link
Contributor

This PR was marked stale due to lack of activity.

@github-actions github-actions bot added the Stale label Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for testing Indicates this PR is ready for integration tests to run Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants