Clean up legacy ContainerInsights #1772
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movence
added
the
ready for testing
sky333999
approved these changes
Jul 16, 2025
the-mann
approved these changes
Jul 16, 2025
|
This PR was marked stale due to lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
There are dead codes that used to support legacy ContainerInsights.
plugins/processors/k8sdecorator(internal/k8sCommon/kubeletutil): related PR Update OTel fork components to dd840b7a79ba22aca7bda3af5cb925ea208c1dc6 #862plugins/processors/ecsdecorator: related commit 858a75eThese functionalities are now supported by the ContainerInsights packages from the contrib
Description of changes
k8sdecoratorandecsdecorator)k8sclient,kubeletutiland others)internal/containerinsightscommoninternal/constants/containerinsights.gometrictransformerprocessorto prefix metric names by resource type (eg.gpu_utilization->node_gpu_utilization)License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Validated ContainerInsights and ApplicationSignals working as expected after this clean up
Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.