Clean up legacy ContainerInsights #1772
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
There are dead codes that used to support legacy ContainerInsights.
plugins/processors/k8sdecorator
(internal/k8sCommon/kubeletutil
): related PR Update OTel fork components to dd840b7a79ba22aca7bda3af5cb925ea208c1dc6 #862plugins/processors/ecsdecorator
: related commit 858a75eThese functionalities are now supported by the ContainerInsights packages from the contrib
Description of changes
k8sdecorator
andecsdecorator
)k8sclient
,kubeletutil
and others)internal/containerinsightscommon
internal/constants/containerinsights.go
metrictransformerprocessor
to prefix metric names by resource type (eg.gpu_utilization
->node_gpu_utilization
)License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Validated ContainerInsights and ApplicationSignals working as expected after this clean up
Requirements
Before commiting your code, please do the following steps.
make fmt
andmake fmt-sh
make lint
Integration Tests
To run integration tests against this PR, add the
ready for testing
label.