-
Notifications
You must be signed in to change notification settings - Fork 233
Add event ID and regex features to CWAgent configuration wizard #1774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Paamicky
wants to merge
3
commits into
feature/windows-regex-filtering
Choose a base branch
from
Update-Config-Wizard
base: feature/windows-regex-filtering
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dricross
reviewed
Jul 14, 2025
07be78f
to
4e7d623
Compare
okankoAMZ
reviewed
Jul 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should re-run make fmt
and make lint
, except for that LGTM
4e7d623
to
0eca2bb
Compare
1fd0ae9
to
1927170
Compare
0eca2bb
to
4ee2142
Compare
0783b84
to
94fcd20
Compare
615200a
to
9fb255f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
The configuration wizard does not support the new CWAgent Windows event filtering features (event ID and regex filtering). This limitation creates a poor customer experience since customers cannot use these features while creating their agent configuration through the wizard.
Description of changes
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Below is the wizard interface for creating a configuration
This is the final configuration for the prompt above
For validation, when a customer enters a wrong event ids, they are prompted and those invalid ids are ignored. For regex you will be asked to input another one. Below is the prompt showing the invalids ids were ignored in the final config.
Below is the final config without the invalid ids:
Requirements
Before commiting your code, please do the following steps.
make fmt
andmake fmt-sh
make lint
Integration Tests
To run integration tests against this PR, add the
ready for testing
label.