feat: allow disabling network and/or storage metric collection only #4420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weeniearms
force-pushed
the
feat/allow-disabling-network-and-storage-metrics
branch
from
efebdab to
409dbe7
Compare
Since not all metrics are likely to be of the same relevance, it would be beneficial from a cost perspective to allow disabling some of them, namely Network IO and Block IO. This change introduces the ability to disable network and storage stats collection via ECS_DISABLE_NETWORK_METRICS and ECS_DISABLE_STORAGE_METRICS respectively.
weeniearms
force-pushed
the
feat/allow-disabling-network-and-storage-metrics
branch
from
409dbe7 to
2cd1a11
Compare
|
Thanks for submitting this pull request. Please submit a feature request at https://github.com/aws/containers-roadmap/issues so that we can prioritize this accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since not all metrics are likely to be of the same relevance, it would be beneficial from a cost perspective to allow disabling some of them, namely Network IO and Block IO.
This change introduces the ability to disable network and storage stats collection via ECS_DISABLE_NETWORK_METRICS and
ECS_DISABLE_STORAGE_METRICS respectively.
Implementation details
Two new config parameters have been introduced that are used in agent/stats/engine.go to conditionally read the network and storage stats.
Testing
Extended existing agent/stats/engine_test.go with new test cases.
New tests cover the changes: yes (extended existing tests with new test cases)
Description for the changelog
Introduced ECS_DISABLE_NETWORK_METRICS and ECS_DISABLE_STORAGE_METRICS configuration variables to allow network and storage stats collection.
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Does this PR include the addition of new environment variables in the README?
Yes. Two new non-sensitive boolean configuration variables.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.