-
Notifications
You must be signed in to change notification settings - Fork 59
feat(cli): allow users to enable all feature flags that do not impact their application #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #798 +/- ##
==========================================
- Coverage 83.64% 82.09% -1.56%
==========================================
Files 65 71 +6
Lines 9558 10350 +792
Branches 1137 1272 +135
==========================================
+ Hits 7995 8497 +502
- Misses 1538 1811 +273
- Partials 25 42 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| const unconfiguredFlags = flagData.filter(flag => | ||
| flag.userValue === undefined && | ||
| isBooleanFlag(flag) && | ||
| (flag.unconfiguredBehavesLike?.v2 !== flag.recommendedValue), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| (flag.unconfiguredBehavesLike?.v2 !== flag.recommendedValue), | |
| ((flag.unconfiguredBehavesLike?.v2 ?? false) !== flag.recommendedValue), |
All the more reason to get this from a single place.
… their application (#798) Allows users to run `cdk flags --safe` to set all unconfigured feature flags to their recommended states without changing their CloudFormation template. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Co-authored-by: Rico Huijbers <[email protected]>
Allows users to run
cdk flags --safeto set all unconfigured feature flags to their recommended states without changing their CloudFormation template.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license